Style: Enforce separation line between function definitions
I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
This commit is contained in:
@ -36,6 +36,7 @@ layout(local_size_x = 8, local_size_y = 8, local_size_z = 1) in;
|
||||
layout(set = 1, binding = 0, std430) restrict buffer LightProbeData {
|
||||
vec4 data[];
|
||||
}
|
||||
|
||||
light_probes;
|
||||
|
||||
layout(set = 1, binding = 1) uniform texture2DArray source_light;
|
||||
@ -93,6 +94,7 @@ layout(push_constant, binding = 0, std430) uniform Params {
|
||||
|
||||
mat3x4 env_transform;
|
||||
}
|
||||
|
||||
params;
|
||||
|
||||
//check it, but also return distance and barycentric coords (for uv lookup)
|
||||
|
||||
Reference in New Issue
Block a user