seedlingattempt/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #103944 from KoBeWi/more_red_info

Browse Source 
Improve error messages for `add_property_info()`
This commit is contained in:
Thaddeus Crews
2025-05-08 07:19:33 -05:00
parent 182be69a1e 602806101c
commit 16aaa0a213
3 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/config/project_settings.cpp
View File

@ -1221,8 +1221,12 @@ Variant _GLOBAL_DEF(const PropertyInfo &p_info, const Variant &p_default, bool p
}
void ProjectSettings::_add_property_info_bind(const Dictionary &p_info) {
ERR_FAIL_COND(!p_info.has("name"));
ERR_FAIL_COND(!p_info.has("type"));
ERR_FAIL_COND_MSG(!p_info.has("name"), "Property info is missing \"name\" field.");
ERR_FAIL_COND_MSG(!p_info.has("type"), "Property info is missing \"type\" field.");
if (p_info.has("usage")) {
WARN_PRINT("\"usage\" is not supported in add_property_info().");
}
PropertyInfo pinfo;
pinfo.name = p_info["name"];

1
doc/classes/ProjectSettings.xml
View File

@ -51,6 +51,7 @@
ProjectSettings.AddPropertyInfo(propertyInfo);
[/csharp]
[/codeblocks]
[b]Note:[/b] Setting [code]"usage"[/code] for the property is not supported. Use [method set_as_basic], [method set_restart_if_changed], and [method set_as_internal] to modify usage flags.
</description>
</method>
<method name="clear">

8
editor/editor_settings.cpp
View File

@ -324,8 +324,12 @@ void EditorSettings::_get_property_list(List<PropertyInfo> *p_list) const {
}
void EditorSettings::_add_property_info_bind(const Dictionary &p_info) {
ERR_FAIL_COND(!p_info.has("name"));
ERR_FAIL_COND(!p_info.has("type"));
ERR_FAIL_COND_MSG(!p_info.has("name"), "Property info is missing \"name\" field.");
ERR_FAIL_COND_MSG(!p_info.has("type"), "Property info is missing \"type\" field.");
if (p_info.has("usage")) {
WARN_PRINT("\"usage\" is not supported in add_property_info().");
}
PropertyInfo pinfo;
pinfo.name = p_info["name"];