From 432b4be1c3b26dd34482ca560e02018569a5b002 Mon Sep 17 00:00:00 2001 From: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com> Date: Fri, 21 Mar 2025 14:08:02 +0100 Subject: [PATCH] Fix incorrect guards in `VisibleOnScreenNotifier2D` Some methods used `DEBUG_ENABLED` instead of `TOOLS_ENABLED`. --- scene/2d/visible_on_screen_notifier_2d.cpp | 4 +++- scene/2d/visible_on_screen_notifier_2d.h | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/scene/2d/visible_on_screen_notifier_2d.cpp b/scene/2d/visible_on_screen_notifier_2d.cpp index 8af3514b1a2..f6d658c99bf 100644 --- a/scene/2d/visible_on_screen_notifier_2d.cpp +++ b/scene/2d/visible_on_screen_notifier_2d.cpp @@ -30,7 +30,7 @@ #include "visible_on_screen_notifier_2d.h" -#ifdef DEBUG_ENABLED +#ifdef TOOLS_ENABLED Dictionary VisibleOnScreenNotifier2D::_edit_get_state() const { Dictionary state = Node2D::_edit_get_state(); state["rect"] = rect; @@ -46,7 +46,9 @@ void VisibleOnScreenNotifier2D::_edit_set_state(const Dictionary &p_state) { void VisibleOnScreenNotifier2D::_edit_set_rect(const Rect2 &p_edit_rect) { set_rect(p_edit_rect); } +#endif // TOOLS_ENABLED +#ifdef DEBUG_ENABLED Rect2 VisibleOnScreenNotifier2D::_edit_get_rect() const { return rect; } diff --git a/scene/2d/visible_on_screen_notifier_2d.h b/scene/2d/visible_on_screen_notifier_2d.h index e775bfe32a8..e4e7cd646ad 100644 --- a/scene/2d/visible_on_screen_notifier_2d.h +++ b/scene/2d/visible_on_screen_notifier_2d.h @@ -54,13 +54,16 @@ protected: static void _bind_methods(); public: -#ifdef DEBUG_ENABLED +#ifdef TOOLS_ENABLED virtual Dictionary _edit_get_state() const override; virtual void _edit_set_state(const Dictionary &p_state) override; virtual Vector2 _edit_get_minimum_size() const override { return Vector2(); } virtual void _edit_set_rect(const Rect2 &p_edit_rect) override; +#endif // TOOLS_ENABLED + +#ifdef DEBUG_ENABLED virtual Rect2 _edit_get_rect() const override; virtual bool _edit_use_rect() const override;