seedlingattempt/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #106164 from lodetrick/refactor-bottom-panel

Browse Source 
Refactor editor `EditorBottomPanel` to be a `TabContainer`
This commit is contained in:
Thaddeus Crews
2025-11-07 10:32:35 -06:00
parent f3c44f00a9 e2caff9a06
commit 522fa8d9bc
18 changed files with 272 additions and 358 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
editor/editor_log.cpp
View File

@ -42,6 +42,7 @@
#include "editor/themes/editor_scale.h"
#include "modules/regex/regex.h"
#include "scene/gui/separator.h"
#include "scene/gui/tab_container.h"
#include "scene/main/timer.h"
#include "scene/resources/font.h"
@ -233,7 +234,7 @@ void EditorLog::_clear_request() {
log->clear();
messages.clear();
_reset_message_counts();
tool_button->set_button_icon(Ref<Texture2D>());
_set_dock_tab_icon(Ref<Texture2D>());
}
void EditorLog::_copy_request() {
@ -284,8 +285,13 @@ void EditorLog::add_message(const String &p_msg, MessageType p_type) {
}
}
void EditorLog::set_tool_button(Button *p_tool_button) {
tool_button = p_tool_button;
void EditorLog::_set_dock_tab_icon(Ref<Texture2D> p_icon) {
// This is the sole reason to include "tab_container.h" here.
TabContainer *parent = Object::cast_to<TabContainer>(get_parent());
if (parent) {
int idx = parent->get_tab_idx_from_control(this);
parent->set_tab_icon(idx, p_icon);
}
}
void EditorLog::register_undo_redo(UndoRedo *p_undo_redo) {
@ -411,7 +417,7 @@ void EditorLog::_add_log_line(LogMessage &p_message, bool p_replace_previous) {
log->push_bold();
log->add_text(" ERROR: ");
log->pop(); // bold
tool_button->set_button_icon(icon);
_set_dock_tab_icon(icon);
} break;
case MSG_TYPE_WARNING: {
log->push_color(theme_cache.warning_color);
@ -420,7 +426,7 @@ void EditorLog::_add_log_line(LogMessage &p_message, bool p_replace_previous) {
log->push_bold();
log->add_text(" WARNING: ");
log->pop(); // bold
tool_button->set_button_icon(icon);
_set_dock_tab_icon(icon);
} break;
case MSG_TYPE_EDITOR: {
// Distinguish editor messages from messages printed by the project