seedlingattempt/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #104689 from Delsin-Yu/csharp-getset-alloc-perf

Browse Source 
[.Net] Avoid unnecessary StringName allocations on not implemented virtual _Get and _Set method call
This commit is contained in:
Thaddeus Crews
2025-04-14 19:39:53 -05:00
parent e1509d533e f0ec392bb1
commit 561dc6ced6
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
modules/mono/glue/GodotSharp/GodotSharp/Core/Bridge/CSharpInstanceBridge.cs
View File

@ -59,6 +59,11 @@ namespace Godot.Bridge
return godot_bool.True; return godot_bool.True;
} }
if (!godotObject.HasGodotClassMethod(GodotObject.MethodName._Set.NativeValue.DangerousSelfRef))
{
return godot_bool.False;
}
var nameManaged = StringName.CreateTakingOwnershipOfDisposableValue( var nameManaged = StringName.CreateTakingOwnershipOfDisposableValue(
NativeFuncs.godotsharp_string_name_new_copy(CustomUnsafe.AsRef(name))); NativeFuncs.godotsharp_string_name_new_copy(CustomUnsafe.AsRef(name)));
@ -107,6 +112,11 @@ namespace Godot.Bridge
return godot_bool.True; return godot_bool.True;
} }
if (!godotObject.HasGodotClassMethod(GodotObject.MethodName._Get.NativeValue.DangerousSelfRef))
{
return godot_bool.False;
}
var nameManaged = StringName.CreateTakingOwnershipOfDisposableValue( var nameManaged = StringName.CreateTakingOwnershipOfDisposableValue(
NativeFuncs.godotsharp_string_name_new_copy(CustomUnsafe.AsRef(name))); NativeFuncs.godotsharp_string_name_new_copy(CustomUnsafe.AsRef(name)));