seedlingattempt/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #27805 from Kanabenki/line2d-add-point-idx

Browse Source 
Add optional position argument for add_point in Line2D
This commit is contained in:
Rémi Verschelde
2019-04-30 11:02:47 +02:00
committed by GitHub
parent ac0369e9ff 714953b3ac
commit 6e1b8b07b9
3 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
doc/classes/Line2D.xml
View File

@ -14,8 +14,11 @@
</return> </return>
<argument index="0" name="position" type="Vector2"> <argument index="0" name="position" type="Vector2">
</argument> </argument>
<argument index="1" name="at_position" type="int" default="-1">
</argument>
<description> <description>
Add a point at the [code]position[/code]. Appends the point at the end of the line. Add a point at the [code]position[/code]. Appends the point at the end of the line.
If [code]at_position[/code] is given, the point is inserted before the point number [code]at_position[/code], moving that point (and every point after) after the inserted point. If [code]at_position[/code] is not given, or is an illegal value ([code]at_position &lt; 0[/code] or [code]at_position &gt;= [method get_point_count][/code]), the point will be appended at the end of the point list.
</description> </description>
</method> </method>
<method name="clear_points"> <method name="clear_points">

10
scene/2d/line_2d.cpp
View File

@ -120,8 +120,12 @@ void Line2D::clear_points() {
} }
} }
void Line2D::add_point(Vector2 pos) { void Line2D::add_point(Vector2 pos, int atpos) {
_points.append(pos); if (atpos < 0 || _points.size() < atpos) {
_points.append(pos);
} else {
_points.insert(atpos, pos);
}
update(); update();
} }
@ -318,7 +322,7 @@ void Line2D::_bind_methods() {
ClassDB::bind_method(D_METHOD("get_point_count"), &Line2D::get_point_count); ClassDB::bind_method(D_METHOD("get_point_count"), &Line2D::get_point_count);
ClassDB::bind_method(D_METHOD("add_point", "position"), &Line2D::add_point); ClassDB::bind_method(D_METHOD("add_point", "position", "at_position"), &Line2D::add_point, DEFVAL(-1));
ClassDB::bind_method(D_METHOD("remove_point", "i"), &Line2D::remove_point); ClassDB::bind_method(D_METHOD("remove_point", "i"), &Line2D::remove_point);
ClassDB::bind_method(D_METHOD("clear_points"), &Line2D::clear_points); ClassDB::bind_method(D_METHOD("clear_points"), &Line2D::clear_points);

2
scene/2d/line_2d.h
View File

@ -72,7 +72,7 @@ public:
void clear_points(); void clear_points();
void add_point(Vector2 pos); void add_point(Vector2 pos, int atpos = -1);
void remove_point(int i); void remove_point(int i);
void set_width(float width); void set_width(float width);