Do not require editor restart when changing manipulator gizmo opacity setting

This commit is contained in:
robert yevdokimov
2025-07-12 19:05:24 +04:00
parent c6d130abd9
commit 728934f43e
3 changed files with 37 additions and 1 deletions

View File

@ -7977,6 +7977,38 @@ void Node3DEditor::_finish_grid() {
}
}
void Node3DEditor::update_gizmo_opacity() {
if (!origin_instance.is_valid()) {
return;
}
const float opacity = EDITOR_GET("editors/3d/manipulator_gizmo_opacity");
for (int i = 0; i < 3; i++) {
Color col = gizmo_color[i]->get_albedo();
col.a = opacity;
gizmo_color[i]->set_albedo(col);
col = gizmo_color_hl[i]->get_albedo();
col.a = 1.0;
gizmo_color_hl[i]->set_albedo(col);
col = plane_gizmo_color[i]->get_albedo();
col.a = opacity;
plane_gizmo_color[i]->set_albedo(col);
col = plane_gizmo_color_hl[i]->get_albedo();
col.a = 1.0;
plane_gizmo_color_hl[i]->set_albedo(col);
}
}
void Node3DEditor::_on_editor_settings_changed() {
if (EditorSettings::get_singleton()->get_changed_settings().has("editors/3d/manipulator_gizmo_opacity")) {
update_gizmo_opacity();
}
}
void Node3DEditor::update_grid() {
const Camera3D::ProjectionType current_projection = viewports[0]->camera->get_projection();
@ -8402,6 +8434,7 @@ void Node3DEditor::_notification(int p_what) {
environ_state->set_custom_minimum_size(environ_vb->get_combined_minimum_size());
ProjectSettings::get_singleton()->connect("settings_changed", callable_mp(this, &Node3DEditor::update_all_gizmos).bind(Variant()));
EditorSettings::get_singleton()->connect("settings_changed", callable_mp(this, &Node3DEditor::_on_editor_settings_changed));
} break;
case NOTIFICATION_ACCESSIBILITY_UPDATE: {
@ -8422,6 +8455,7 @@ void Node3DEditor::_notification(int p_what) {
case NOTIFICATION_EXIT_TREE: {
_finish_indicators();
EditorSettings::get_singleton()->disconnect("settings_changed", callable_mp(this, &Node3DEditor::_on_editor_settings_changed));
} break;
case NOTIFICATION_THEME_CHANGED: {

View File

@ -805,6 +805,7 @@ private:
HashMap<Control *, VSeparator *> context_toolbar_separators;
void _update_context_toolbar();
void _on_editor_settings_changed();
void _generate_selection_boxes();
@ -969,6 +970,7 @@ public:
void update_grid();
void update_transform_gizmo();
void update_all_gizmos(Node *p_node = nullptr);
void update_gizmo_opacity();
void snap_selected_nodes_to_floor();
void select_gizmo_highlight_axis(int p_axis);
void set_custom_camera(Node *p_camera) { custom_camera = p_camera; }

View File

@ -945,7 +945,7 @@ void EditorSettings::_load_defaults(Ref<ConfigFile> p_extra_config) {
// 3D: Manipulator
EDITOR_SETTING(Variant::INT, PROPERTY_HINT_RANGE, "editors/3d/manipulator_gizmo_size", 80, "16,160,1");
EDITOR_SETTING_USAGE(Variant::FLOAT, PROPERTY_HINT_RANGE, "editors/3d/manipulator_gizmo_opacity", 0.9, "0,1,0.01", PROPERTY_USAGE_DEFAULT | PROPERTY_USAGE_RESTART_IF_CHANGED)
EDITOR_SETTING(Variant::FLOAT, PROPERTY_HINT_RANGE, "editors/3d/manipulator_gizmo_opacity", 0.9, "0,1,0.01")
// 2D
_initial_set("editors/2d/grid_color", Color(1.0, 1.0, 1.0, 0.07), true);