seedlingattempt/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix PropertyListHelper::_get_property returning a valid value even if an index is outside the array valid indices

Browse Source 
Co-authored-by: Tomasz Chabora <kobewi4e@gmail.com>
This commit is contained in:
Gilles Roudière
2024-05-09 14:19:16 +02:00
parent c4279fe3e0
commit 7705265477
12 changed files with 52 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
scene/gui/option_button.cpp
View File

@ -571,6 +571,7 @@ void OptionButton::_bind_methods() {
PopupMenu::Item defaults(true);
base_property_helper.set_prefix("popup/item_");
base_property_helper.set_array_length_getter(&OptionButton::get_item_count);
base_property_helper.register_property(PropertyInfo(Variant::STRING, "text"), defaults.text, &OptionButton::_dummy_setter, &OptionButton::get_item_text);
base_property_helper.register_property(PropertyInfo(Variant::OBJECT, "icon", PROPERTY_HINT_RESOURCE_TYPE, "Texture2D"), defaults.icon, &OptionButton::_dummy_setter, &OptionButton::get_item_icon);
base_property_helper.register_property(PropertyInfo(Variant::INT, "id", PROPERTY_HINT_RANGE, "0,10,1,or_greater"), defaults.id, &OptionButton::_dummy_setter, &OptionButton::get_item_id);