seedlingattempt/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #104556 from Ivorforce/string-extend-instead-of-parse

Browse Source 
Use `append_` instead of `parse_` for `String` methods.
This commit is contained in:
Thaddeus Crews
2025-03-29 10:16:33 -05:00
parent 6bab3c07fc ffa6ef220b
commit 780cf03051
62 changed files with 245 additions and 274 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/multiplayer/scene_cache_interface.cpp
View File

@ -101,7 +101,7 @@ void SceneCacheInterface::process_simplify_path(int p_from, const uint8_t *p_pac
int ofs = 1;
String methods_md5;
methods_md5.parse_utf8((const char *)(p_packet + ofs), 32);
methods_md5.append_utf8((const char *)(p_packet + ofs), 32);
ofs += 33;
int id = decode_uint32(&p_packet[ofs]);
@ -110,7 +110,7 @@ void SceneCacheInterface::process_simplify_path(int p_from, const uint8_t *p_pac
ERR_FAIL_COND_MSG(peers_info[p_from].recv_nodes.has(id), vformat("Duplicate remote cache ID %d for peer %d", id, p_from));
String paths;
paths.parse_utf8((const char *)(p_packet + ofs), p_packet_len - ofs);
paths.append_utf8((const char *)(p_packet + ofs), p_packet_len - ofs);
const NodePath path = paths;

2
modules/multiplayer/scene_rpc_interface.cpp
View File

@ -136,7 +136,7 @@ Node *SceneRPCInterface::_process_get_node(int p_from, const uint8_t *p_packet,
ERR_FAIL_COND_V_MSG(ofs >= p_packet_len, nullptr, "Invalid packet received. Size smaller than declared.");
String paths;
paths.parse_utf8((const char *)&p_packet[ofs], p_packet_len - ofs);
paths.append_utf8((const char *)&p_packet[ofs], p_packet_len - ofs);
NodePath np = paths;