From 3ae88632e2bfc11902790d6e7b23bd8d0ba4e557 Mon Sep 17 00:00:00 2001 From: Koyper Date: Thu, 27 Nov 2025 08:53:34 -0600 Subject: [PATCH] Fix redundant attempts to connect popup hidden signal on submenu --- scene/gui/popup_menu.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scene/gui/popup_menu.cpp b/scene/gui/popup_menu.cpp index e179c911a58..bd57047b709 100644 --- a/scene/gui/popup_menu.cpp +++ b/scene/gui/popup_menu.cpp @@ -1924,7 +1924,7 @@ void PopupMenu::add_submenu_node_item(const String &p_label, PopupMenu *p_submen RID submenu_rid = p_submenu->bind_global_menu(); nmenu->set_item_submenu(global_menu, index, submenu_rid); items.write[index].submenu_bound = true; - } else { + } else if (!p_submenu->is_connected("popup_hide", callable_mp(this, &PopupMenu::_submenu_hidden))) { p_submenu->connect("popup_hide", callable_mp(this, &PopupMenu::_submenu_hidden)); } @@ -2221,7 +2221,7 @@ void PopupMenu::set_item_submenu_node(int p_idx, PopupMenu *p_submenu) { NativeMenu::get_singleton()->set_item_submenu(global_menu, p_idx, submenu_rid); items.write[p_idx].submenu_bound = true; } - } else { + } else if (!p_submenu->is_connected("popup_hide", callable_mp(this, &PopupMenu::_submenu_hidden))) { p_submenu->connect("popup_hide", callable_mp(this, &PopupMenu::_submenu_hidden)); } control->queue_redraw();