seedlingattempt/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #101033 from Ivorforce/string-count-avoid-copy

Browse Source 
Optimize `_count` by replacing a full copy with a CoW copy for the full-string count case.
This commit is contained in:
Rémi Verschelde
2025-01-09 11:17:17 +01:00
parent 892f77d5af b2d881a73a
commit a7052a2bd0
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/string/ustring.cpp
View File

@ -3707,8 +3707,7 @@ int String::_count(const String &p_string, int p_from, int p_to, bool p_case_ins
return 0;
}
if (p_from == 0 && p_to == len) {
str = String();
str.copy_from_unchecked(&get_data()[0], len);
str = *this;
} else {
str = substr(p_from, p_to - p_from);
}
@ -3744,8 +3743,7 @@ int String::_count(const char *p_string, int p_from, int p_to, bool p_case_insen
return 0;
}
if (p_from == 0 && search_limit == source_length) {
str = String();
str.copy_from_unchecked(&get_data()[0], source_length);
str = *this;
} else {
str = substr(p_from, search_limit - p_from);
}