seedlingattempt/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #76560 from aaronfranke/node-set-string-name

Browse Source 
Change Node `set_name` to use StringName, slightly improves performance
This commit is contained in:
Thaddeus Crews
2025-05-02 09:25:25 -05:00
parent bec3856cec a404b668a1
commit acf38b2292
6 changed files with 69 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
modules/mono/editor/bindings_generator.cpp
View File

@ -2732,11 +2732,7 @@ Error BindingsGenerator::_generate_cs_property(const BindingsGenerator::TypeInte
if (getter && setter) {
const ArgumentInterface &setter_first_arg = setter->arguments.back()->get();
if (getter->return_type.cname != setter_first_arg.type.cname) {
// Special case for Node::set_name
bool whitelisted = getter->return_type.cname == name_cache.type_StringName &&
setter_first_arg.type.cname == name_cache.type_String;
ERR_FAIL_COND_V_MSG(!whitelisted, ERR_BUG,
ERR_FAIL_V_MSG(ERR_BUG,
"Return type from getter doesn't match first argument of setter for property: '" +
p_itype.name + "." + String(p_iprop.cname) + "'.");
}