seedlingattempt/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Further refactoring to AudioDriver implementations after #69120.

Browse Source 
- Rename all instances of `capture_start()` and `capture_end()` to their new
  names. Fixes #72892.
- More internal renames to match what was started in #69120.
- Use `override` consistently so that such refactoring bugs can be caught.
- Harmonize the order of definition of the overridden virtual methods in each
  audio driver.
- Harmonize prototype for `set_output_device` and `set_input_device`.

Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
This commit is contained in:
Emmanouil Papadeas
2023-02-08 17:40:15 +02:00
committed by Rémi Verschelde
parent d69809cab6
commit c36460060e
22 changed files with 227 additions and 215 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/xaudio2/audio_driver_xaudio2.cpp
View File

@ -33,10 +33,6 @@
#include "core/config/project_settings.h"
#include "core/os/os.h"
const char *AudioDriverXAudio2::get_name() const {
return "XAudio2";
}
Error AudioDriverXAudio2::init() {
active.clear();
exit_thread.clear();

21
drivers/xaudio2/audio_driver_xaudio2.h
View File

@ -91,16 +91,19 @@ class AudioDriverXAudio2 : public AudioDriver {
XAudio2DriverVoiceCallback voice_callback;
public:
const char *get_name() const;
virtual const char *get_name() const override {
return "XAudio2";
}
virtual Error init();
virtual void start();
virtual int get_mix_rate() const;
virtual SpeakerMode get_speaker_mode() const;
virtual float get_latency();
virtual void lock();
virtual void unlock();
virtual void finish();
virtual Error init() override;
virtual void start() override;
virtual int get_mix_rate() const override;
virtual SpeakerMode get_speaker_mode() const override;
virtual float get_latency() override;
virtual void lock() override;
virtual void unlock() override;
virtual void finish() override;
AudioDriverXAudio2();
~AudioDriverXAudio2() {}