seedlingattempt/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allow chunk validator to wrap around in RID_Alloc so that we do not need to crash once we have made 2^31 allocations

Browse Source
This commit is contained in:
clayjohn
2025-04-17 23:35:34 -07:00
parent 09ea7bc6a3
commit c6c06a966a
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/templates/rid_owner.h
View File

@ -164,8 +164,7 @@ class RID_Alloc : public RID_AllocBase {
uint32_t free_chunk = free_index / elements_in_chunk;
uint32_t free_element = free_index % elements_in_chunk;
uint32_t validator = (uint32_t)(_gen_id() & 0x7FFFFFFF);
CRASH_COND_MSG(validator == 0x7FFFFFFF, "Overflow in RID validator");
uint32_t validator = 1 + (uint32_t)(_gen_id() % 0x7FFFFFFF);
uint64_t id = validator;
id <<= 32;
id |= free_index;
@ -329,7 +328,7 @@ public:
uint32_t validator = uint32_t(id >> 32);
bool owned = (validator != 0x7FFFFFFF) && (chunks[idx_chunk][idx_element].validator & 0x7FFFFFFF) == validator;
bool owned = (chunks[idx_chunk][idx_element].validator & 0x7FFFFFFF) == validator;
if constexpr (THREAD_SAFE) {
mutex.unlock();