From cc2649acdb7bd39b10a581153e73ae68581613d8 Mon Sep 17 00:00:00 2001
From: kobewi <kobewi4e@gmail.com>
Date: Sun, 2 Mar 2025 14:55:30 +0100
Subject: [PATCH] Validate custom type script before loading it

---
 editor/scene_tree_dock.cpp | 1 +
 scene/property_utils.cpp   | 7 +++++++
 2 files changed, 8 insertions(+)

diff --git a/editor/scene_tree_dock.cpp b/editor/scene_tree_dock.cpp
index 2bc022f1d1c..267d35f9945 100644
--- a/editor/scene_tree_dock.cpp
+++ b/editor/scene_tree_dock.cpp
@@ -3115,6 +3115,7 @@ void SceneTreeDock::_replace_node(Node *p_node, Node *p_by_node, bool p_keep_pro
 		// If we're dealing with a custom node type, we need to create a default instance of the custom type instead of the native type for property comparison.
 		if (oldnode->has_meta(SceneStringName(_custom_type_script))) {
 			Ref<Script> cts = PropertyUtils::get_custom_type_script(oldnode);
+			ERR_FAIL_COND_MSG(cts.is_null(), "Invalid custom type script.");
 			default_oldnode = Object::cast_to<Node>(get_editor_data()->script_class_instance(cts->get_global_name()));
 			if (default_oldnode) {
 				default_oldnode->set_name(cts->get_global_name());
diff --git a/scene/property_utils.cpp b/scene/property_utils.cpp
index dc9a56a294a..75c16a4228d 100644
--- a/scene/property_utils.cpp
+++ b/scene/property_utils.cpp
@@ -306,5 +306,12 @@ Ref<Script> PropertyUtils::get_custom_type_script(const Object *p_object) {
 		return script_object;
 	}
 #endif
+	ResourceUID::ID id = ResourceUID::get_singleton()->text_to_id(custom_script);
+	if (unlikely(id == ResourceUID::INVALID_ID || !ResourceUID::get_singleton()->has_id(id))) {
+		const_cast<Object *>(p_object)->remove_meta(SceneStringName(_custom_type_script));
+		ERR_FAIL_V_MSG(Ref<Script>(), vformat("Invalid custom type script UID: %s. Removing.", custom_script.operator String()));
+	} else {
+		custom_script = ResourceUID::get_singleton()->get_id_path(id);
+	}
 	return ResourceLoader::load(custom_script);
 }