seedlingattempt/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix: Windows OS.get_unique_id() null termination issue

Browse Source 
use ascii for encoding-neutral
check buffer size as well
This commit is contained in:
uno1982
2025-05-03 04:47:31 -05:00
parent 7a0ab9d561
commit d79258c2e7
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
platform/windows/os_windows.cpp
View File

@ -2437,7 +2437,9 @@ String OS_Windows::get_user_data_dir(const String &p_user_dir) const {
String OS_Windows::get_unique_id() const { String OS_Windows::get_unique_id() const {
HW_PROFILE_INFOA HwProfInfo; HW_PROFILE_INFOA HwProfInfo;
ERR_FAIL_COND_V(!GetCurrentHwProfileA(&HwProfInfo), ""); ERR_FAIL_COND_V(!GetCurrentHwProfileA(&HwProfInfo), "");
return String::ascii(Span((HwProfInfo.szHwProfileGuid), HW_PROFILE_GUIDLEN));
// Note: Windows API returns a GUID with null termination.
return String::ascii(Span<char>(HwProfInfo.szHwProfileGuid, strnlen(HwProfInfo.szHwProfileGuid, HW_PROFILE_GUIDLEN)));
} }
bool OS_Windows::_check_internal_feature_support(const String &p_feature) { bool OS_Windows::_check_internal_feature_support(const String &p_feature) {