seedlingattempt/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove editor pseudolocalization debug feature

Browse Source 
We've seen multiple users enable it by mistake and get utterly confused,
reporting as a bug that the interface text is garbled.

On the other hand we haven't really seen much use of the feature by editor
UI developers, so we can likely simply remove it.

If there's a need eventually, we can re-add it as a command line option
(which is also better than an editor setting as one would typically want
to toggle it during development).
This commit is contained in:
Rémi Verschelde
2024-06-24 15:48:01 +02:00
parent e78dc83ee8
commit f11e8d033d
4 changed files with 2 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/string/translation.cpp
View File

@ -752,10 +752,10 @@ StringName TranslationServer::tool_translate(const StringName &p_message, const
if (tool_translation.is_valid()) {
StringName r = tool_translation->get_message(p_message, p_context);
if (r) {
return editor_pseudolocalization ? tool_pseudolocalize(r) : r;
return r;
}
}
return editor_pseudolocalization ? tool_pseudolocalize(p_message) : p_message;
return p_message;
}
StringName TranslationServer::tool_translate_plural(const StringName &p_message, const StringName &p_message_plural, int p_n, const StringName &p_context) const {
@ -856,10 +856,6 @@ void TranslationServer::set_pseudolocalization_enabled(bool p_enabled) {
}
}
void TranslationServer::set_editor_pseudolocalization(bool p_enabled) {
editor_pseudolocalization = p_enabled;
}
void TranslationServer::reload_pseudolocalization() {
pseudolocalization_accents_enabled = GLOBAL_GET("internationalization/pseudolocalization/replace_with_accents");
pseudolocalization_double_vowels_enabled = GLOBAL_GET("internationalization/pseudolocalization/double_vowels");

2
core/string/translation.h
View File

@ -94,7 +94,6 @@ class TranslationServer : public Object {
bool pseudolocalization_fake_bidi_enabled = false;
bool pseudolocalization_override_enabled = false;
bool pseudolocalization_skip_placeholders_enabled = false;
bool editor_pseudolocalization = false;
float expansion_ratio = 0.0;
String pseudolocalization_prefix;
String pseudolocalization_suffix;
@ -170,7 +169,6 @@ public:
bool is_pseudolocalization_enabled() const;
void set_pseudolocalization_enabled(bool p_enabled);
void set_editor_pseudolocalization(bool p_enabled);
void reload_pseudolocalization();
String standardize_locale(const String &p_locale) const;